-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Token Exchange Profile #1119
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
+ Coverage 89.20% 89.22% +0.01%
==========================================
Files 130 134 +4
Lines 18156 18296 +140
==========================================
+ Hits 16196 16324 +128
- Misses 1387 1395 +8
- Partials 573 577 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duedares-rvj added some feedback please take a look!
@@ -0,0 +1 @@ | |||
package tokenexchangeprofile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can't see any test cases here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the test and the recordings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -67,7 +67,7 @@ resource "auth0_action" "my_action" { | |||
|
|||
- `dependencies` (Block Set) List of third party npm modules, and their versions, that this action depends on. (see [below for nested schema](#nestedblock--dependencies)) | |||
- `deploy` (Boolean) Deploying an action will create a new immutable version of the action. If the action is currently bound to a trigger, then the system will begin executing the newly deployed version of the action immediately. | |||
- `runtime` (String) The Node runtime. Defaults to `node18`. Possible values are: `node16` (not recommended), or `node18` (recommended). | |||
- `runtime` (String) The Node runtime. Possible values are: `node12`, `node16` (not recommended), `node18`, `node22` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call out the current Default value for runTime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Computed value is node22, so we should not call out a default. the default depends on the kind of trigger.
🔧 Changes
Added new resource and data-source
auth0_token_exchange_profile
Added support to set
token_exchange
forauth0_client
resource📚 References
Auth0 Management API: Token Exchange Profiles Documentation
POST Token Exchange Profile
GET All Token Exchange Profiles
GET Token Exchange Profile by ID
PATCH Token Exchange Profile
DELETE Token Exchange Profile
🔬 Testing
Relevant test cases has been added:
make test-acc FILTER=TestTokenExchangeProfile
📝 Checklist